Remove tfjob operator from sdk #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @gaoning777 |
|
I opposed the inclusion of this component in the SDK. I added it to satisfy @qimingj's completion criteria for the "Strongly-typed DSL components" task. |
Ark-kun
approved these changes
Nov 13, 2018
|
@qimingj I think we need to remove one of the two copies. Which one should we remove? |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
* Need to pin version of pipenv to a newer version to fix the bux. Fix kubeflow#233
HumairAK
referenced
this pull request
in red-hat-data-services/data-science-pipelines
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this operator should belong to the sdk, and it already exist in
https://github.com/kubeflow/pipelines/tree/master/components/kubeflow/launcher
Please correct me if this is not the case.
This change is