[MKP/doc] Update doc for changes of service account credential. #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2019 09:09
james-jwu
reviewed
Oct 4, 2019
manifests/gcp_marketplace/guide.md
Outdated
|
|
||
| Existing key also can be used. | ||
|
|
||
| Then we can create and inject service account credential. |
There was a problem hiding this comment.
"Then you can create ..."
|
/lgtm |
|
/lgtm /approved |
|
/lgtm |
|
/approve |
|
cc @jessiezcc |
|
/assign @neuromage |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: james-jwu, neuromage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
paveldournov
reviewed
Oct 5, 2019
| @@ -134,15 +128,10 @@ export MARKETPLACE_TOOLS_IMAGE=gcr.io/cloud-marketplace-staging/marketplace-k8s- | |||
| Run the install script | |||
|
|
|||
| ```shell | |||
| mpdev scripts/install --deployer=gcr.io/ml-pipeline/google/pipelines/deployer:0.2 --parameters='{"name": "'$APP_INSTANCE_NAME'", "namespace": "'$NAMESPACE'", "serviceAccountCredential": "'$SERVICE_ACCOUNT_TOKEN'"}' | |||
| mpdev scripts/install --deployer=gcr.io/ml-pipeline/google/pipelines/deployer:0.1 --parameters='{"name": "'$APP_INSTANCE_NAME'", "namespace": "'$NAMESPACE'"}' | |||
There was a problem hiding this comment.
Is the image tag getting decreased to 0.1 expected?
There was a problem hiding this comment.
Currently for alpha launch, we'll pin the version to 0.1, so yes.
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Add pod rbac for kserve controller Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Update torchserve 0.6.0 Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Update torchserve kfs image Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflect changes made in #2308
This change is