Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MKP] Remove service account credential from deployment page. #2308

Merged
merged 2 commits into from
Oct 9, 2019
Merged

[MKP] Remove service account credential from deployment page. #2308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
524b0fb
Finalize. Add todo
Oct 4, 2019
8d9b47d
Remove
Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/gcp_marketplace/chart/kubeflow-pipelines/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ images:
metadataenvoy: gcr.io/ml-pipeline/google/pipelines/metadataenvoy:0.1.31

gcpSecretName: "user-gcp-sa"
serviceAccountCredential: null
serviceAccountCredential: ""

managedstorage:
enabled: false
Expand Down
16 changes: 2 additions & 14 deletions manifests/gcp_marketplace/schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,20 +100,8 @@ properties:
type: string
x-google-marketplace:
type: NAMESPACE
serviceAccountCredential:
title: |-
GCP Service Account credentials used to call other GCP services.
description: |-
This deployment requires a service account to use for authentication when calling other GCP services.
Specify the base64-encoded credentials for the service account you want to use.
You can get these credentials by running the following command in a terminal window.
\"$ gcloud iam service-accounts keys create application_default_credentials.json --iam-account [your-service-account] && cat application_default_credentials.json | base64\"
If you are using Linux, please use \"base64 -w 0\" to disable line wrapping.
type: string
default: ""
x-google-marketplace:
type: STRING

required:
- name
- namespace
- serviceAccountCredential