Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests - Simplified test/sample-test/run_tests.sh a bit #230

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Tests - Simplified test/sample-test/run_tests.sh a bit #230

merged 1 commit into from
Nov 14, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 13, 2018 •
edited by jlewi
Loading

This change is Reviewable

@Ark-kun Ark-kun requested a review from gaoning777 November 13, 2018 09:06
@coveralls
Copy link

Pull Request Test Coverage Report for Build 281

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.531%
Totals Coverage Status
Change from base Build 279: 0.0%
Covered Lines: 1542
Relevant Lines: 2193
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 325

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.531%
Totals Coverage Status
Change from base Build 279: 0.0%
Covered Lines: 1542
Relevant Lines: 2193
💛 - Coveralls

gaoning777
gaoning777 approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for updating the sed command such that it looks much cleaner.
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1eb0adf into master Nov 14, 2018
@Ark-kun Ark-kun deleted the avolkov/Tests---Simplified-test/sample-test/run_tests.sh-a-bit branch January 15, 2019 22:09
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@richardsliu @k8s-ci-robot
Fix gcs directory path for periodic Prow jobs (kubeflow#230)
b1e2071 
* Fix gcs directory

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 approved these changes

Assignees

@gaoning777 gaoning777

Labels
approved area/testing lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @coveralls @k8s-ci-robot @gaoning777