Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Component] Add VPC Interface Endpoint Support for SageMaker #2299

Merged
merged 3 commits into from
Oct 4, 2019
Merged

[Component] Add VPC Interface Endpoint Support for SageMaker #2299

merged 3 commits into from
Oct 4, 2019

Conversation

RedbackThomson
Copy link
Contributor

@RedbackThomson RedbackThomson commented Oct 3, 2019 •
edited by jlewi
Loading

Adds the ability to define a VPC interface endpoint as a configuration option for all Sagemaker components.

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @RedbackThomson. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Jeffwan
Jeffwan approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward.

samples/contrib/aws-samples/mnist-kmeans-sagemaker/mnist-classification-pipeline.py
@@ -93,6 +94,7 @@ def mnist_classification(region='us-west-2',

hpo = sagemaker_hpo_op(
region=region,
endpoint_url=endpoint_url,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some of the common parameters which will be applied on all operators, we probably like to come up a different way to configure them since they don't need fine grain control.

@Jeffwan
Copy link
Member

Jeffwan commented Oct 3, 2019

/ok-to-test

@Jeffwan
Copy link
Member

Jeffwan commented Oct 4, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2fe8c0d into kubeflow:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeffwan Jeffwan Jeffwan approved these changes

@mameshini mameshini Awaiting requested review from mameshini

Assignees

@Jeffwan Jeffwan

Labels
approved lgtm ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RedbackThomson @k8s-ci-robot @Jeffwan