Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Containers - Renamed constructor parameter in the private ContainerBuilder class #2261

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 27, 2019

This change is Reviewable

Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

…ameter-in-the-private-ContainerBuilder-class
@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 17, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 17, 2019

@SinaChavoshi I had to fix merge conflict.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 5, 2019

@SinaChavoshi Gentle ping.

Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@SinaChavoshi
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 7, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6eb00e7 into kubeflow:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants