Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support ppcle64 in pipelines/frontend #2234

Closed
wants to merge 1 commit into from

Conversation

QxiaoQ
Copy link
Contributor

@QxiaoQ QxiaoQ commented Sep 25, 2019

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jingzhang36
You can assign the PR to them by writing /assign @jingzhang36 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @QxiaoQ. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QxiaoQ
Copy link
Contributor Author

QxiaoQ commented Sep 25, 2019

@jinchihe

@jinchihe
Copy link
Member

/ok-to-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 25, 2019

What are the changes here?

@QxiaoQ QxiaoQ changed the title Support ppcle64 in pipelines/frontend [WIP] Support ppcle64 in pipelines/frontend Oct 9, 2019
@Bobgy
Copy link
Contributor

Bobgy commented Oct 15, 2019

/area front-end

@rmgogogo
Copy link
Contributor

Any background introduction?
Please be noticed we don't have plan to support ppcle64 and won't test it for future changes.
In such case, better put this file to other repo and refer this repo.

Would like to know more first.

Maybe the file can be put to https://github.com/kubeflow/pipelines/tree/master/contrib/ppcle64.

@rmgogogo rmgogogo removed their request for review October 25, 2019 11:59
@Bobgy
Copy link
Contributor

Bobgy commented Feb 22, 2020

/close
resolved by #3113
because we no longer use backstop js, so no dependency on phantomjs now

@k8s-ci-robot
Copy link
Contributor

@Bobgy: Closed this PR.

In response to this:

/close
resolved by #3113
because we no longer use backstop js, so no dependency on phantomjs now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants