Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component] Fix the image version specification in create cluster component. #2213

Merged

Conversation

numerology
Copy link

@numerology numerology commented Sep 24, 2019

Should fix #2211


This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 24, 2019

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 24, 2019

@hongye-sun Is there some test suite that we could use to test executing the code of GCP components?

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 24, 2019

tests/google/dataproc/test__create_cluster.py:94: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
.tox/py35/lib/python3.5/site-packages/mock/mock.py:944: in assert_called_with
    six.raise_from(AssertionError(_error_message(cause)), cause)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
value = None, from_value = None
>   ???
E   AssertionError: expected call not found.
E   Expected: create_cluster('mock_project', 'mock-region', {'clusterName': 'test-cluster', 'config': {'initializationActions': [{'executableFile': 'gs://action/1'}, {'executableFile': 'gs://action/2'}], 'configBucket': 'gs://config/bucket'}, 'softwareConfig': {'imageVersion': '1.10'}, 'projectId': 'mock_project', 'labels': {'label-1': 'value-1'}}, request_id='ctx1')
E   Actual: create_cluster('mock_project', 'mock-region', {'clusterName': 'test-cluster', 'config': {'softwareConfig': {'imageVersion': '1.10'}, 'initializationActions': [{'executableFile': 'gs://action/1'}, {'executableFile': 'gs://action/2'}], 'configBucket': 'gs://config/bucket'}, 'projectId': 'mock_project', 'labels': {'label-1': 'value-1'}}, request_id='ctx1')

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 24, 2019

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 24, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology
Copy link
Author

/retest

@numerology
Copy link
Author

/test kubeflow-pipeline-sample-test

@k8s-ci-robot k8s-ci-robot merged commit 1914fa2 into kubeflow:master Sep 25, 2019
@numerology numerology deleted the fix-create-cluster-image-version branch October 2, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] GCP dataproc create_cluster component cannot correctly specify image_version.
5 participants