Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push pipeline-lite YAML as part of release CB #2186

Merged
merged 11 commits into from
Sep 23, 2019
+10 −0
Merged

push pipeline-lite YAML as part of release CB #2186

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ea579fc
small fixes
IronPan Sep 17, 2019
4331f93
small fixes
IronPan Sep 17, 2019
6baa768
Merge remote-tracking branch 'upstream/master'
IronPan Sep 17, 2019
f244388
Merge remote-tracking branch 'upstream/master'
IronPan Sep 18, 2019
d040dc3
Merge remote-tracking branch 'upstream/master'
IronPan Sep 19, 2019
9f4ad5b
Merge remote-tracking branch 'upstream/master'
IronPan Sep 20, 2019
8b8cafe
Merge remote-tracking branch 'upstream/master'
IronPan Sep 21, 2019
66bedf7
push pipeline-lite YAML as part of release
IronPan Sep 21, 2019
87141bc
Delete Makefile
IronPan Sep 21, 2019
1a965b2
push pipeline-lite YAML as part of release
IronPan Sep 21, 2019
0f629fc
Merge branch 'release30' of https://github.com/IronPan/pipelines into…
IronPan Sep 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .release.cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,16 @@ steps:
id: 'copyPythonComponentSDKToLatest'
waitFor: ['copyPythonComponentSDKLocal']

# Generate and copy the pipeline-lite deployment YAML
- name: 'google/cloud-sdk'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Tasks are mush easier to parse when they're separated by an empty line and the id is the first attribute.

args: ['kustomize', '/workspace/manifests/kustomize/env/dev', 'namespaced-install.yaml']
id: 'generateDeploymentYaml'
- name: 'gcr.io/cloud-builders/gsutil'
args: ['cp', 'namespaced-install.yaml', 'gs://ml-pipeline/pipeline-lite/$TAG_NAME/namespaced-install.yaml']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should replace gs://ml-pipeline/ with gs://kf-pipelines/ in future?

id: 'copyDeploymentYaml'
waitFor: ['generateDeploymentYaml']


images:
- 'gcr.io/ml-pipeline/frontend:$TAG_NAME'
- 'gcr.io/ml-pipeline/frontend:$COMMIT_SHA'
Expand Down