Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove tfx-taxi sample in favor of the tfx oss sample #2160

Merged
merged 1 commit into from
Sep 19, 2019
Merged

remove tfx-taxi sample in favor of the tfx oss sample #2160

merged 1 commit into from
Sep 19, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Sep 18, 2019 •
edited by jlewi
Loading

This change is Reviewable

This was referenced Sep 18, 2019
Closed
Merged
@gaoning777
Copy link
Contributor Author

fixing #1903

@numerology
Copy link

/lgtm

@numerology
Copy link

Also, two files in the website need change
https://github.com/kubeflow/website/blob/05d3d9233205ad926b0baa3f5e1f6a5bfc5c0689/content/docs/pipelines/sdk/build-component.md
and
https://github.com/kubeflow/website/blob/cf7b9f3a87c30cdd3aaf2089bbe9cbbb5220d774/content/docs/pipelines/sdk/output-viewer.md

@gaoning777
Copy link
Contributor Author

Also, two files in the website need change
https://github.com/kubeflow/website/blob/05d3d9233205ad926b0baa3f5e1f6a5bfc5c0689/content/docs/pipelines/sdk/build-component.md
and
https://github.com/kubeflow/website/blob/cf7b9f3a87c30cdd3aaf2089bbe9cbbb5220d774/content/docs/pipelines/sdk/output-viewer.md

Thanks for pointing that out. I'm in fact in the middle of sending that PR.

@gaoning777
Copy link
Contributor Author

/approve

@neuromage
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777, neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a855c56 into kubeflow:master Sep 19, 2019
@gaoning777 gaoning777 deleted the remove-tfx-old branch September 19, 2019 16:47
@cvenets
Copy link

cvenets commented Sep 24, 2019

Hello @gaoning777, can you please explain the reason for this PR?

Why are we removing this example? We are heavily relying on this example to showcase the e2e Taxi Cab pipeline running on-prem, and produce tutorials.

cc: @jinchihe @jessiezcc @jlewi

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@Suresh-Nakkeran
Convert kserve manager from statefulset to deployment to make HA (kub…
27f9052 
…eflow#2160)

* Convert kserve manager from statefulset to deployment to make HA

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* update nvidia cuda latest image

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@neuromage neuromage

@numerology numerology

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaoning777 @numerology @neuromage @k8s-ci-robot @cvenets