-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execution detail page shows inputs and outputs #2155
Conversation
@@ -1,10 +1,14 @@ | |||
{ | |||
"compilerOptions": { | |||
"allowSyntheticDefaultImports": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allows code like import React, { Component } from 'react'
Note, this is based on #2153 |
This is great, thanks @Bobgy! Would it be possible to make the inputs/outputs linkable? |
@neuromage it is already linkable. The first video were taken before I made the linkable feature. |
Since @ajayalfred has LGTMed. I will merge this. |
/lgtm |
@Bobgy: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, neuromage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Part of #2086
video 1 - initial implementation: https://drive.google.com/file/d/1ZegAxrewO_fDLHOZUkJ7JixPmpoOeMkc/view
video 2 - deep link in artifact id: https://drive.google.com/file/d/1UFPrBf7-afdu80uOLvDZLynxEnkmKcMR/view
Final screenshot
@neuromage Any feedback about this?
/area front-end
/kind feature
/assign @IronPan
/cc @neuromage
This change is