Tests - Samples - Added the component_build sample test #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoning777
reviewed
Sep 18, 2019
b599ba4 to
faf2f47
Compare
|
/lgtm |
faf2f47 to
4f17ce3
Compare
4f17ce3 to
6471f36
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-sample-test |
|
trigger the sample tests a couple of times to make sure it is consistently working. |
|
The error is not because of this PR. #2170 |
|
/retest |
|
The tests are passing |
|
/lgtm |
|
fixing #1813 |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
kubeflow#2147) * Add Volumes to ServingRuntimePodSpec; allow other built-in ServerTypes Update unit tests to cover merging volumes, and improve environment variable merging. Signed-off-by: Nick Hill <nickhill@us.ibm.com> * Address some review comments Signed-off-by: Nick Hill <nickhill@us.ibm.com> * Change to use strategic merge patch from k8s apimachinery Signed-off-by: Nick Hill <nickhill@us.ibm.com> * Change container args merge behaviour to concatenate Also rename a coreContainer var to mergedContainer. Signed-off-by: Nick Hill <nickhill@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2109
This change is