Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission issue running GCP pipelines #2129

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Sep 16, 2019

The GCP pipelines currently requires user-gcp-sa.json in the user-gcp-sa.
Add the token will ensure the pipelines calling GCP services continue to work.
/assign @rmgogogo


This change is Reviewable

@rmgogogo
Copy link
Contributor

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Sep 17, 2019

/test kubeflow-pipeline-sample-test

@IronPan
Copy link
Member Author

IronPan commented Sep 17, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member Author

IronPan commented Sep 17, 2019

tests failures are irrelavent

@IronPan IronPan merged commit 0efdb55 into kubeflow:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants