Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Started to explicitly import submodules into kfp namespace #2117

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 13, 2019

Previously, some submodules like containers were not getting imported.


This change is Reviewable

@kevinbache
Copy link
Contributor

/lgtm

@kevinbache
Copy link
Contributor

/approve

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 14, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, kevinbache

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3ec743a into kubeflow:master Sep 14, 2019
@Ark-kun Ark-kun deleted the SDK---Started-to-explicitly-import-submodules-into-kfp-namespace branch September 14, 2019 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants