-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a convention to make sure experiment_name is parameterized in notebook sample. #2112
Add a convention to make sure experiment_name is parameterized in notebook sample. #2112
Conversation
/test kubeflow-pipeline-e2e-test |
/test kubeflow-pipeline-sample-test |
1 similar comment
/test kubeflow-pipeline-sample-test |
/lgtm If we modify |
'default' experiment actually sounds sweet. Although there is a caveat: currently the sample test infra assumes that each sample test is running under an experiment where there is only one pipeline run. If we put all runs under the same default experiment, we need to change that logic accordingly. Thanks for proposing the environment variable approach, that could be convenient, but we need to design a mechanism to make sure the domain of its function. Let's think about it a bit more. |
/approve |
/hold |
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777, numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test kubeflow-pipeline-sample-test |
/test kubeflow-pipline-sample-test |
/test kubeflow-pipeline-sample-test |
1 similar comment
/test kubeflow-pipeline-sample-test |
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
Otherwise it's hard for the sample test infra to pick up the pipeline run results after submitting for a run.\
See #2110 .
This change is