Adds Metadata Artifacts to UI #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ok for console.log and TODO
8070f27 to
f4cf332
Compare
neuromage
reviewed
Sep 6, 2019
| RUN apt-get update && \ | ||
| apt-get install gettext -y | ||
|
|
||
| ENTRYPOINT ["/envoy-entrypoint.sh"] |
There was a problem hiding this comment.
I think we can dispense with the entrypoint script, and just run /usr/local/bin/envoy -c /etc/envoy.yaml here
There was a problem hiding this comment.
Sounds good. Will change this in the follow-up
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neuromage, rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds pages for listing and viewing metadata artifacts, as well as configuration for an envoy proxy that handles connections to the metadata gRPC server.
A follow-up will add pages for executions.
This change is