add us to OWNERS for SHA #2047
add us to OWNERS for SHA #2047
Conversation
|
/retest |
|
/assign @IronPan |
|
/lgtm |
|
/hold |
|
Could you add to just frontend for now? |
|
@rmgogogo Can this just be frontend for now? |
|
I removed Yuan and I but put Jing to owner list as prefer at least one people from SHA to co operate it. |
|
@rmgogogo You may not really need root OWNER here. Is there something outside frontend that you'll be working on, that you think will be impacted by the possible one day latency? If so, should we consider moving that to a separate directory? I think files like cloudbuild config are good candidates for this. WDYT? I definitely don't want to slow SHA team down, but I'm not sure if this will make a material difference. It is also worth noting that you have write permission to this repository, so if an emergency fix is needed, you can use this mechanism (as a last resort of course, but it will work). |
|
Updated |
|
@IronPan can you approve this one? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
/retest |
|
/test kubeflow-pipeline-sample-test |
2 similar comments
|
/test kubeflow-pipeline-sample-test |
|
/test kubeflow-pipeline-sample-test |
|
/retest |
Add us to OWNERS for SHA
This change is