SDK - Refactoring - Reduced the usage of dsl.Pipeline context #2034
Conversation
Also reduced the unnecessary explicit usage of PipelineParam bu the end users
| @@ -153,6 +154,7 @@ def _extract_component_metadata(func): | |||
| arg_type = None | |||
| arg_default = arg_defaults[arg] if arg in arg_defaults else None | |||
| if isinstance(arg_default, PipelineParam): | |||
| warnings.warn('Explicit creation of `kfp.dsl.PipelineParam`s by the users is deprecated. The users should define the parameter type and default values using standard pythonic constructs: def my_func(a: int = 1, b: str = "default"):') | |||
There was a problem hiding this comment.
Shall we provide a way to suppress this warning, like a flag --verbose, or it needs to go out anyway?
There was a problem hiding this comment.
I'm not sure we need a way to disable it since the pipeline definitions did not need PipelineParams since the first public release and it's very easy to fix the issue (and make the pipeline function signature much smaller and nicer in the process).
…sl.Pipeline-context
|
@numerology Can you re-LGTM please? I had to fix merge conflict. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* add mlflow support Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com> * added e2e test for lightgbm, mlflow models with mlserver Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
This class is private and should only be used by the compiler.
Also reduced the unnecessary explicit usage of PipelineParam by the end users.
This PR is pure refactoring. Some changes are whitespace/indentation-only.
This change is