-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change sample test to read test arguments from yaml config file #1987
Change sample test to read test arguments from yaml config file #1987
Conversation
Could we add a readme to explain the steps to add a sample test? |
Sure thing. Will do that in another PR. |
/lgtm |
If not the readme, could you provide the spec about the config yaml in this PR? I think this should be a minimal work such as
This will be important because users need to know what the sample test infra is expecting from the configuration. |
Just to confirm. Are you talking about add this spec in a separated file, or inline in the comment in the config.yaml itself? |
/lgtm |
/lgtm |
/test kubeflow-pipeline-sample-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#1987) * update copyright info in openapi Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com> * updated copyright info Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
Part of #1750
Now the params used for each sample test live in test/sample-test/configs dir. If no config file is provided, default param values will be used. Also, common constants used in sample test infra are moved into a dedicated python file.
Moving image injection and into config files guideline of adding a sample test will be in following PRs.
This change is