test/project-cleanup - fix #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the missing packages issue in project-cleanup job. Issue: project cleanup job runs in Prow and uses kubekins-e2e image, which in turn uses go-1.12 version and enlists the source in $GOPATH/src directory, the packages specified in go.mod file are not discovered. The fix is to install the packages using go-get, and has been tested using the kubekins-e2e image. The change also has some minor logging fixes to the project-cleanup tool.
|
/assign @IronPan @neuromage |
|
/lgtm |
neuromage
suggested changes
Aug 27, 2019
| @@ -81,7 +81,13 @@ func (p *ProjectCleaner) GKEClusterHandler(resource GCPResource) { | |||
| log.Printf("Listing gke clusters in zone: %v", zone) | |||
| listResponse, err := svc.Projects.Zones.Clusters.List(p.ProjectId, zone).Do() | |||
| if err != nil { | |||
| log.Printf("Failed listing gke clusters in zone: %v", zone) | |||
There was a problem hiding this comment.
log.Errorf ? same below?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neuromage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ajchili
pushed a commit
to ajchili/pipelines
that referenced
this pull request
Aug 28, 2019
This change fixes the missing packages issue in project-cleanup job. Issue: project cleanup job runs in Prow and uses kubekins-e2e image, which in turn uses go-1.12 version and enlists the source in $GOPATH/src directory, the packages specified in go.mod file are not discovered. The fix is to install the packages using go-get, and has been tested using the kubekins-e2e image. The change also has some minor logging fixes to the project-cleanup tool.
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Refactor image transformer and add to test Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Validate v2 rest protocol inputs Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Use PULL_BASE_SHA tag for image transformer test Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Default to v1 protocol Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Fix validation and add transformer image github action Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the missing packages issue in project-cleanup job.
Issue: project cleanup job runs in Prow and uses kubekins-e2e image, which in turn uses go-1.12 version and enlists the source in $GOPATH/src directory, the packages specified in go.mod file are not discovered. The fix is to install the packages using go-get, and has been tested using the kubekins-e2e image.
The change also has some minor logging fixes to the project-cleanup tool.
This change is