Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Components - Add support for the Base64Pickle type #1946

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Aug 24, 2019

Pickle data contains zero bytes, but command-line arguments do not support them. So to pass argument through command-line we have to encode it to text. I used the popular Base64 encoding to convert the binary pickle data to string.


This change is Reviewable

@Ark-kun Ark-kun force-pushed the SDK---Components---Add-support-for-the-Base64Pickle-type branch from ba43481 to 600023a Compare August 26, 2019 21:26
@ajchili
Copy link
Member

ajchili commented Aug 26, 2019

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 26, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d043d16 into kubeflow:master Aug 27, 2019
ajchili pushed a commit to ajchili/pipelines that referenced this pull request Aug 28, 2019
* SDK - Components - Add support for the Base64Pickle type

* Make flake8 happy
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants