Tests/Minikube - Fix Google credentials #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test presubmit-e2e-test |
|
The credentials work now. |
|
/approve |
|
@IronPan Can you please check this? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun, vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
`dep` installed via the install script gets the latest version of `dep`. If a contributor installs `dep` via `apt-get`, for example, they might push a dependency that would be removed if someone were running `dep` installed via the script: `dep` installed via `apt-get` ignores the [[prune]] section of Gopkg.toml while `dep` installed via the script does not. Also, `dep` via `apt-get` removes `pruneopts` etc (which are present when you run `dep` installed via the script), rewriting ~67% of Godep.lock, when someone tries to add a new dependency.
HumairAK
referenced
this pull request
in red-hat-data-services/data-science-pipelines
Mar 11, 2024
HumairAK
referenced
this pull request
in red-hat-data-services/data-science-pipelines
Mar 11, 2024
Merge v1.5.1 to Stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is