SDK - Components - Setting default base image or image factory #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added kfp.components.set_default_base_image which sets the name of the container image that will be used for component creation when base_image is not specified. Alternatively, the base image can also be set to a factory function that will be returning the image. The support is added for both Lightweight components and python container components.
numerology
reviewed
Aug 26, 2019
| @@ -207,7 +220,7 @@ def annotation_to_type_struct(annotation): | |||
| return component_spec | |||
|
|
|||
|
|
|||
| def _func_to_component_spec(func, extra_code='', base_image=_default_base_image, modules_to_capture: List[str] = None, use_code_pickling=False) -> ComponentSpec: | |||
| def _func_to_component_spec(func, extra_code='', base_image : str = None, modules_to_capture: List[str] = None, use_code_pickling=False) -> ComponentSpec: | |||
There was a problem hiding this comment.
Shall we type-check the extra_code too?
numerology
reviewed
Aug 26, 2019
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ajchili
pushed a commit
to ajchili/pipelines
that referenced
this pull request
Aug 28, 2019
…low#1937) Added kfp.components.set_default_base_image which sets the name of the container image that will be used for component creation when base_image is not specified. Alternatively, the base image can also be set to a factory function that will be returning the image. The support is added for both Lightweight components and python container components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added kfp.components.set_default_base_image which sets the name of the container image that will be used for component creation when base_image is not specified.
Alternatively, the base image can also be set to a factory function that will be returning the image.
The support is added for both Lightweight components and python container components.
This change is