SDK - Components - Improved serialization and deserialization of arguments and defaults #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments and defaults Properly serialize default values and passed arguments using the same code. Check the types of passed argument values and issue warnings. Improved argument reference type compatibility checking. When types do not match there is always either error or warning. When creating component from python function, the input types are now canonicalized.
347e4fb to
5857568
Compare
numerology
reviewed
Aug 23, 2019
numerology
reviewed
Aug 23, 2019
0376ca3 to
f20ed59
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Update CE Handling Signed-off-by: Mark Winter <mark.winter@navercorp.com> * Update avro test case Signed-off-by: Mark Winter <mark.winter@navercorp.com> * Fix return type Signed-off-by: Mark Winter <mark.winter@navercorp.com> * Return cloudevent data for non-json events Signed-off-by: Mark Winter <mark.winter@navercorp.com> * Remove type Signed-off-by: Mark Winter <mark.winter@navercorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves serialization and deserialization of arguments and defaults
The PR is mostly a refactoring.
It's prerequisite for fixing #1488 and #1901
Properly serialize default values and passed arguments using the same code.
Check the types of passed argument values and issue warnings.
Improved argument reference type compatibility checking. When types do not match there is always either error or warning.
When creating component from python function, the input types are now canonicalized.
This change is