Sample test improvement - using python fire to launch sample test #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 7dbca1a Author: Ning <ngao@google.com> Date: Fri Aug 16 12:06:37 2019 -0700 update gcloud ml-engine to ai-platform (kubeflow#1863) commit e849f22 Author: Ryan Dawson <ryandawson@cantab.net> Date: Fri Aug 16 19:21:23 2019 +0100 Seldon examples (kubeflow#1405) commit a6f3f40 Author: sina chavoshi <sina.chavoshi@gmail.com> Date: Fri Aug 16 09:56:09 2019 -0700 Adding a sample for serving component (kubeflow#1830) * Adding a sample for serving component * removed typo / updated based on PR feedback * fixing the jupyter rendering issue * adding pip3 for tensorflow * Fixed spelling error in VERSION * fix indentation based on review feedback commit 54ff3e6 Author: Alexey Volkov <avolkov@google.com> Date: Fri Aug 16 01:22:31 2019 -0700 SDK - Cleanup - Serialized PipelineParamTuple does not need value or type (kubeflow#1469) * SDK - Refactoring - Serialized PipelineParam does not need type Only the types in non-serialized PipelineParams are ever used. * SDK - Refactoring - Serialized PipelineParam does not need value Default values are only relevant when PipelineParam is used in the pipeline function signature and even in this case compiler captures them explicitly from the pipelineParam objects in the signature. There is no other uses for them. commit d2e94e4 Author: Riley Bauer <34456002+rileyjbauer@users.noreply.github.com> Date: Thu Aug 15 19:52:34 2019 -0700 Fix run duration bug (kubeflow#1827) * Allows durations >=24h and renames 'showLink' in RunList * Update, fix tests commit d8eaeaa Author: Alexey Volkov <avolkov@google.com> Date: Thu Aug 15 17:25:59 2019 -0700 SDK - Preserving the pipeline input information in the compiled Workflow (kubeflow#1381) * SDK - Preserving the pipeline metadata in the compiled Workflow * Stabilizing the DSL compiler tests commit afe8a69 Author: Kirin Patel <kirinpatel@gmail.com> Date: Thu Aug 15 17:00:28 2019 -0700 Reduce API usage by utilizing reference name in reference resource API (kubeflow#1824) * Regenerated run api for frontend * Added support for reference name to resource reference API in frontend * Revert "Regenerated run api for frontend" * Addressed PR comments * Removed extra if statement by setting default value of parameter * Removed the whole comment * Addressed PR feedback * Addressed PR feedback * Simplified logic after offline discussion commit ea67c99 Author: Kirin Patel <kirinpatel@gmail.com> Date: Thu Aug 15 16:18:35 2019 -0700 Change how Variables are Provided to Visualizations (kubeflow#1754) * Changed way visualization variables are passed from request to NotebookNode Visualization variables are now saved to a json file and loaded by a NotebookNode upon execution. * Updated roc_curve visualization to reflect changes made to dependency injection * Fixed bug where checking if is_generated is provided to roc_curve visualization would crash visualizaiton Also changed ' -> " * Changed text_exporter to always sort variables by key for testing * Addressed PR suggestions commit d238bef Author: Jiaxiao Zheng <jxzheng@google.com> Date: Thu Aug 15 12:55:29 2019 -0700 Add back coveralls. (kubeflow#1849) * Remove redundant import. * Simplify sample_test.yaml by using withItem syntax. * Simplify sample_test.yaml by using withItem syntax. * Change dict to str in withItems. * Add back coveralls. commit 0517114 Author: Riley Bauer <34456002+rileyjbauer@users.noreply.github.com> Date: Thu Aug 15 12:28:35 2019 -0700 Reduce getPipeline calls in RunList (kubeflow#1852) * Skips calling getPipeline in RunList if the pipeline name is in the pipeline_spec * Update fixed data to include pipeline names in pipeline specs * Remove redundant getRuns call commit 39e5840 Author: IronPan <yangpa@google.com> Date: Thu Aug 15 11:04:34 2019 -0700 Add retry button in Pipeline UI (kubeflow#1782) * add retry button * add retry button * add retry button * address comments * fix tests * fix tests * update image * Update StatusUtils.test.tsx * Update RunDetails.test.tsx * Update Buttons.ts * update test * update frontend * update * update * addrerss comments * update test
step 1, presubmit check triggered by fire.
step 2, add ComponentTest class
Rewrite dockerfile
Merge branch 'master' of https://github.com/kubeflow/pipelines into test-improvement # Conflicts: # sdk/python/tests/compiler/testdata/retry.yaml
commit 0ed5819 Author: Yuan (Bob) Gong <gongyuan94@gmail.com> Date: Tue Aug 20 08:13:31 2019 +0800 Refactor presubmit-tests-with-pipeline-deployment.sh to run in other projects (kubeflow#1732) * Refactor presubmit-tests-with-pipeline-deployment.sh so that it can be run from a different project * Simplify getting service account from cluster. * Copy image builder image instead of granting permission * Add missed yes command * fix stuff * Let other usages of image-builder image become configurable * let test workflow use image builder image
gaoning777
reviewed
Aug 23, 2019
gaoning777
reviewed
Aug 23, 2019
added 2 commits
August 22, 2019 19:34
commit 7b6825d Author: hongye-sun <43763191+hongye-sun@users.noreply.github.com> Date: Thu Aug 22 18:23:18 2019 -0700 Update changelog for 0.1.27 (kubeflow#1935) * Update changelog for 0.1.27 * Revert unexpected changes. commit 336760c Author: IronPan <yangpa@google.com> Date: Thu Aug 22 17:47:18 2019 -0700 sync namespaced install file (kubeflow#1932) commit 55d62fe Author: Hamed <hamedhsn@gmail.com> Date: Fri Aug 23 01:09:18 2019 +0100 Support Affinity for ContainerOps (kubeflow#1886) commit d15697b Author: Animesh Singh <singhan@us.ibm.com> Date: Thu Aug 22 16:29:17 2019 -0700 Initial kfserving pipeline component (kubeflow#1838) * initial kfserving pipeline component * changing some descriptions * adding action as an input, and pinning versions * moving Dockerfile in correct location * adding namespace to delete commit 119405d Author: hongye-sun <43763191+hongye-sun@users.noreply.github.com> Date: Thu Aug 22 15:49:29 2019 -0700 upgrade backend image versions (kubeflow#1918) commit c01315a Author: Alexey Volkov <avolkov@google.com> Date: Thu Aug 22 15:31:24 2019 -0700 SDK - Refactoring - Replaced the TypeMeta class (kubeflow#1930) * SDK - Refactoring - Replaced the TypeMeta class The PipelineParam no longer exposes the private TypeMeta class Fixes kubeflow#1420 The refactoring PR is part of a series of PR which unifies the metadata and specification types. commit 736c7a5 Author: IronPan <yangpa@google.com> Date: Thu Aug 22 15:29:19 2019 -0700 clean up owner file (kubeflow#1928) commit 5abba66 Author: Kirin Patel <kirinpatel@gmail.com> Date: Thu Aug 22 14:45:18 2019 -0700 Add pipeline id to pipeline summary card (kubeflow#1927) * Added pipeline id to pipeline summary card * Updated PipelineDetails.test.tsx.snap commit 3c8952e Author: Kirin Patel <kirinpatel@gmail.com> Date: Thu Aug 22 13:57:20 2019 -0700 Add TFDV, TFMA, and Table visualization support for Python based visualizations (kubeflow#1898) * Added table and tfdv visualization Also fixed issue surrounding ApiVisualizationType enum * Fixed table visualization * Removed byte limit * Fixed issue where headers would not properly be applied * Fixed issue where table would not be intractable * Updated table visualizaiton to reflect changes made to dependency injection * Fixed bug where checking if headers is provided to table visualizations could crash visualization * Added TFMA visualization * Updated new visualizations to match syntax of kubeflow#1878 * Updated test snapshots to account for TFMA visualization * Small if statement synax changes * Add flake8 noqa comments to table.py and tfma.py commit db6c9b4 Author: dushyanthsc <43390008+dushyanthsc@users.noreply.github.com> Date: Thu Aug 22 13:11:18 2019 -0700 pipeline-lite: Introduce metadata component to pipeline-lite (kubeflow#1840) This change introduces the metadata component to pipeline-lite installation. This installation: 1. Does not include metadata-ui 2. mysql installation is used instead of metadata-db 3. Replica count has been reduced 1 instead of 3
added 9 commits
August 22, 2019 21:28
gaoning777
reviewed
Aug 23, 2019
test/sample-test/utils.py
Outdated
| blob.upload_from_filename(source_file_name) | ||
| except: | ||
| raise RuntimeError('Failure when uploading %s from %s to %s' |
There was a problem hiding this comment.
The errors that GCS python throws might still help. For example, get_bucket throws bucket_not_found exception. What do you think of outputting this message before re-throwing the caught exception?
gaoning777
reviewed
Aug 23, 2019
test/sample-test/utils.py
Outdated
| except: | ||
| raise RuntimeError('Failure when uploading %s from %s to %s' | ||
| % (source_file_name, bucket_name, destination_blob_name)) | ||
| except google.cloud.exceptions.GoogleCloudError as e: |
There was a problem hiding this comment.
FYI, except's can be combined as such:
try:
except A:
except B:
added 2 commits
August 23, 2019 13:54
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @numerology , this PR seems to break postsubmit test. Would you mind double check what went wrong there? |
NP. I'll do a quick fix. Sorry for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from bash script to python fire fore better manageability.
Example command line usage:
(Sample test run): python sample_test_launcher.py sample_test run_test --arg1 value1 --arg2 value2
(Sample test run): python sample_test_launcher.py component_test run_test --arg1 value1 --arg2 value2
Component test is defined as a derived class of sample test to reduce dup logic.
A step of #1750
This change is