Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release b8afd0418f55362112d1fbe077fdd7da2737c500 #1799

Conversation

kevinbache
Copy link
Contributor

@kevinbache kevinbache commented Aug 10, 2019

Also contains some upgrades to release.sh


This change is Reviewable

@kevinbache
Copy link
Contributor Author

/assign ark-kun gaoning777

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 10, 2019

Are you sure that this PR has been produced by the release.sh script? There are some aspects that are notably different. Also this PR is notably bigger than the usual release PRs.

Let's check whether something went wrong.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ironpan
You can assign the PR to them by writing /assign @ironpan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kevinbache
Copy link
Contributor Author

/retest

@kevinbache
Copy link
Contributor Author

it was produced on a mac which added a few newlines. also the tests are passing now that our service accounts have been cleared out again.

@Ark-kun Ark-kun assigned IronPan and unassigned Ark-kun Aug 12, 2019
@IronPan
Copy link
Member

IronPan commented Aug 12, 2019

could you remove the formatting change from this PR?

@kevinbache
Copy link
Contributor Author

@IronPan do you mean the newlines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants