Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test #17

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Test #17

merged 1 commit into from
Nov 2, 2018

Conversation

kubeflow-pipeline-bot
Copy link
Contributor

@kubeflow-pipeline-bot kubeflow-pipeline-bot commented Nov 2, 2018

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: yebrahim

If they are not already assigned, you can assign the PR to them by writing /assign @yebrahim in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@google-prow-robot
Copy link
Collaborator

@kubeflow-pipeline-bot: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
mlpipeline-build-image 75b2559 link /test mlpipeline-build-image
mlpipeline-presubmit-unit-test 75b2559 link /test mlpipeline-presubmit-unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubeflow-pipeline-bot
Copy link
Contributor Author

This is a test.

@kubeflow-pipeline-bot
Copy link
Contributor Author

I signed it!

1 similar comment
@kubeflow-pipeline-bot
Copy link
Contributor Author

I signed it!

@vicaire
Copy link
Contributor

vicaire commented Nov 2, 2018

/lgtm

@vicaire vicaire merged commit c4769ed into master Nov 2, 2018
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Reasons for change:

Would like a link directly from a PR to the corresponding argo workflow to make debugging easier
Changes made:

Add calls to run_e2e_workflow.py for setting github status to pending, success, or failure
Adds github_status.py for sending status update
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
This reverts commit eaa8e90.

The original commit requires GIT_TOKEN environment variable to be set;
but its not set on the prow jobs.
HumairAK referenced this pull request in HumairAK/data-science-pipelines Mar 9, 2024
Add ability to mount self-signed certs to dsp v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants