Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic component build sample #1681

Merged
merged 8 commits into from
Aug 8, 2019
Merged

Basic component build sample #1681

merged 8 commits into from
Aug 8, 2019

Conversation

SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented Jul 25, 2019 •
edited by jlewi
Loading

Adding a basic sample to demonstrate component build functionality to address #1033

This change is Reviewable

@SinaChavoshi SinaChavoshi mentioned this pull request Jul 25, 2019
Closed
@SinaChavoshi SinaChavoshi requested a review from numerology July 26, 2019 00:12
numerology
numerology reviewed Jul 26, 2019
View reviewed changes
@Ark-kun Ark-kun self-assigned this Jul 26, 2019
@googlebot
Copy link
Collaborator

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@numerology
Copy link

One quick question: I'm a little bit of confused about the workflow here. Should this change gets committed to master or build_basic_components_sample?

@SinaChavoshi
Copy link
Contributor Author

One quick question: I'm a little bit of confused about the workflow here. Should this change gets committed to master or build_basic_components_sample?

This change should be committed to master.

@SinaChavoshi SinaChavoshi changed the base branch from basic_component_build_sample to master August 5, 2019 23:52
@SinaChavoshi
Copy link
Contributor Author

/retest

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@numerology numerology self-requested a review August 6, 2019 16:01
numerology
numerology approved these changes Aug 6, 2019
View reviewed changes
Copy link

@numerology numerology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@SinaChavoshi
Update samples/core/component_build/component_build.py
360b772 
Co-Authored-By: Jiaxiao Zheng <jxzheng@google.com>
@numerology
Copy link

/lgtm

@SinaChavoshi
Copy link
Contributor Author

/assign @Ark-kun

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 6, 2019
@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Aug 7, 2019
@gaoning777
Copy link
Contributor

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 7, 2019

/retest

@SinaChavoshi
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@k8s-ci-robot k8s-ci-robot merged commit c07e975 into kubeflow:master Aug 8, 2019
@SinaChavoshi SinaChavoshi deleted the basic_component_build_sample branch September 27, 2019 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Ark-kun left review comments

@numerology numerology numerology approved these changes

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@Ark-kun Ark-kun

@gaoning777 gaoning777

@numerology numerology

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SinaChavoshi @googlebot @numerology @gaoning777 @k8s-ci-robot @Ark-kun