Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move gcshelper out of component_builder #1658

Merged
merged 2 commits into from
Jul 24, 2019
Merged

move gcshelper out of component_builder #1658

merged 2 commits into from
Jul 24, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Jul 24, 2019

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 24, 2019

/lgtm
Maybe later we should move all container-building code to kfp.containers.

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

2 similar comments
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 24, 2019

/test kubeflow-pipeline-sample-test

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 24, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 24, 2019

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777 gaoning777 merged commit 46aafbd into kubeflow:master Jul 24, 2019
@gaoning777 gaoning777 deleted the refactor-component-build branch July 24, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants