Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trims whitespace from pipeline params on creation of new run #1605

Merged

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Jul 9, 2019

Fixes #162


This change is Reviewable

@rileyjbauer
Copy link
Contributor Author

/retest kubeflow-pipeline-sample-test

@rileyjbauer
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor

@SinaChavoshi What do you think of trimming the spaces in the pipeline input?

@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 15, 2019

/lgtm

@gaoning777
Copy link
Contributor

verified with sina offline. It's reasonable to trim the spaces/tabs in the input params during the run creation.
/lgtm

@rileyjbauer
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rileyjbauer
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@rileyjbauer rileyjbauer force-pushed the trim-whitespace-from-params branch from c7e0504 to 78a6ca3 Compare July 16, 2019 21:36
@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 16, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 17, 2019

/lgtm
Note that in future we might start getting requests to add the ability to turn this off.
There are some legitimate cases to want control over whitespace. The simplest is when the user wants to specify column separator character (usually space or tab).

@k8s-ci-robot k8s-ci-robot merged commit 48c46bd into kubeflow:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline input cleansing
5 participants