-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trims whitespace from pipeline params on creation of new run #1605
Trims whitespace from pipeline params on creation of new run #1605
Conversation
/retest kubeflow-pipeline-sample-test |
/test kubeflow-pipeline-sample-test |
@SinaChavoshi What do you think of trimming the spaces in the pipeline input? |
/lgtm |
verified with sina offline. It's reasonable to trim the spaces/tabs in the input params during the run creation. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test kubeflow-pipeline-e2e-test |
c7e0504
to
78a6ca3
Compare
/lgtm |
Fixes #162
This change is