Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added image captioning sample to samples/notebooks #1591

Merged
merged 11 commits into from
Jul 23, 2019
Merged

Added image captioning sample to samples/notebooks #1591

merged 11 commits into from
Jul 23, 2019

Conversation

zanedurante
Copy link
Contributor

@zanedurante zanedurante commented Jul 3, 2019 •
edited by jlewi
Loading

Adding example of image captioning in preparation for docs sprint (kubeflow/website#737).

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @zanedurante. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zanedurante zanedurante changed the title [WIP] Added image captioning sample to samples/notebooks Added image captioning sample to samples/notebooks Jul 15, 2019
@gaoning777
Copy link
Contributor

Update note: I successfully run it in my cluster.
I'll send some review feedback soon.

@gaoning777 gaoning777 self-assigned this Jul 17, 2019
@gaoning777
Copy link
Contributor

/ok-to-test

@gaoning777
Copy link
Contributor

gaoning777 commented Jul 18, 2019 •
edited
Loading

Hey, Zane
You might need to git push so that I can see the new changes.

@zanedurante
Copy link
Contributor Author

I was going to push when the final change (base image location) was made, I'll push the changes now though.

@zanedurante
Copy link
Contributor Author

Any idea why the test failed?

@zanedurante
Copy link
Contributor Author

/retest

@zanedurante
Copy link
Contributor Author

/retest

@gaoning777
Copy link
Contributor

Could we enlarge the font a bit, similar to https://github.com/kubeflow/pipelines/blob/master/samples/notebooks/KubeFlow%20Pipeline%20Using%20TFX%20OSS%20Components.ipynb
Use ## or # instead of ###

@zanedurante
Copy link
Contributor Author

I increased all of the title sizes by 1 to be consistent

@gaoning777
Copy link
Contributor

/lgtm

@gaoning777
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor

Thanks for contribution and all the efforts to address the feedback.

@zanedurante
Copy link
Contributor Author

Thanks for the feedback, the sample definitely improved!

@k8s-ci-robot k8s-ci-robot merged commit 5124078 into kubeflow:master Jul 23, 2019
@zanedurante zanedurante mentioned this pull request Jul 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 left review comments

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@gaoning777 gaoning777

Labels
approved lgtm ok-to-test size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanedurante @k8s-ci-robot @gaoning777