Viewer CRD controller running under namespace #1562
Conversation
|
/assign @IronPan |
| @@ -42,6 +43,9 @@ var ( | |||
| maxNumViewers = flag.Int("max_num_viewers", 50, | |||
| "Maximum number of viewer instances allowed within "+ | |||
| "the cluster before the controller starts deleting the oldest one.") | |||
| namespace = flag.String("namespace", "kubeflow", | |||
There was a problem hiding this comment.
can we expose this through CRD container Dockerfile?
Here is an example
https://github.com/kubeflow/pipelines/blob/master/backend/Dockerfile.scheduledworkflow#L21
https://github.com/kubeflow/pipelines/blob/master/manifests/namespaced-install/ml-pipeline-scheduledworkflow-deployment-patch.yaml#L10
There was a problem hiding this comment.
Done. And the default namespace is set to be "kubeflow".
|
/assign @IronPan |
|
/assign @IronPan |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change is