SDK - Relative imports #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made all SDK import relative so that they files always refer to the sibling files instead of the installed package. This makes debugging and development easier since you can be sure the correct files are used.
eb42598 to
c39a636
Compare
qimingj
approved these changes
Nov 10, 2018
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qimingj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test presubmit-e2e-test |
|
/test build-image |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
* Exclude all vendor directories from lint tests. * Fix lint.
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* add download injector
* add download injector
* merge deployment mutators
* add framework method to control mapping from source to local
* move annotations to constants
* move default mount path to constants
* adding missing import for constants in frameworks
* fix tests to account for mapping
* mess around with paths
* actually make the downloader an init contianer
* add pvc:// support
* make parts of pvc path explicit in test
* rename dockerfile
* provisioner makefile
* use logging
* refactor as predictor-initializer
* rename to model initailizer
* udpate message when user container not found
* use only one annotation
* linting
* rename injector to model initializer
* actually call renamed function
* more renames
* move uri validation to validating webhook
* rename to mutator
* make slice of mutators
* use container from gcr.io
* add get model source uri to tensorrt spec
* fix merge error
* fix tests to account for annotation
* use constant in tests
* rename mount location
* fix typo
* fix linter errors
* fix annotation name.. the old one failed with this error:
message: 'Revision creation failed with message: Revision.serving.knative.dev
"tensorrt-simple-string-default-qp5q2" is invalid: metadata.annotations: Invalid
value: "serving.kubeflow.org/internal/model-initializer/sourceURI": a qualified
name must consist of alphanumeric characters, ''-'', ''_'' or ''.'', and must
start and end with an alphanumeric character (e.g. ''MyName'', or ''my.name'', or
''123-abc'', regex used for validation is ''([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]'')
with an optional DNS subdomain prefix and ''/'' (e.g. ''example.com/MyName'').'
* fix annotation name in reconciler tests
* add method to pytorch
* attempt to make constants nicer
* use ref for user contaner and add failure test
* add comments to clarify usage
* revert bad change
HumairAK
referenced
this pull request
in red-hat-data-services/data-science-pipelines
Mar 11, 2024
* rename main step name to main * also update resourceop container name to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made all SDK import relative so that they files always refer to the sibling files instead of the installed package. This makes debugging and development easier since you can be sure the correct files are used.
This change is