-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activate public prow service account #153
Conversation
/assign @Ark-kun |
test/presubmit-tests-gce-minikube.sh
Outdated
@@ -33,6 +33,9 @@ instance_name=${instance_name:-test-minikube-${PULL_PULL_SHA:0:6}-$(date +%s)-$( | |||
|
|||
firewall_rule_name=allow-prow-ssh-$instance_name | |||
|
|||
# activating the service account | |||
gcloud auth activate-service-account --key-file=${GOOGLE_APPLICATION_CREDENTIALS} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would quote the variables, also let's see if presubmit passes
/retest |
/test build-image |
/test presubmit-unit-test |
(probably takes a while to populate...) |
/test build-image |
/test build-image |
/test presubmit-unit-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
* activate service account * Update presubmit-tests-gce-minikube.sh * Update presubmit-tests.gke.sh * Update presubmit-tests.sh * update git clone * update image * update image * Removed the SSH key copying * update git clone * update image * update
* Check if status and phase is set in argo workflow crd Sometimes it takes a while for the argo controller to populate the status field of an object. Fixes kubeflow/testing#147 * Update * Update
* initial pytorch support * modifying go crd files * modifying go crd files * test placeholder * cleaning up test placeholder file * updating with cifar10 sample * updating cifar10 instructions * correcting docker steps * adding pytorch doeckerfile * removing generated data files * correcting the sample pytorch yaml file * adding the class file and class name parameters * adding cifar10 input file and dockerfile * adding gcs location for model file * addressing review comments * simplifying PyTorch interface * making model class name optional * fix the comment ordering * removing model file * adding default behaviour
* updated compiler * update the tests * Update affinity.yaml * Update compiler.py * Update compiler.py * Update affinity.yaml Put back the license.
This change is