Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Improving python component logs by making stdout and stderr unbuffered #1510

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jun 14, 2019

Without this the output and error lines can be printed in wrong order and sometimes not printed at all.


This change is Reviewable

…uffered

Without this the output and error lines can be printed in wrong order and sometimes not printed at all.
@hongye-sun
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 14, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit aee1b5e into kubeflow:master Jun 14, 2019
@Ark-kun Ark-kun deleted the SDK---Improving-python-component-logs-by-making-stdout-and-stderr-unbuffered branch June 18, 2019 06:33
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Added test for https downloader

* update invalid prefix test case

* Added https protocol and updated GetAllProtocol

* added https provider case

* set up https download for uncompressed/gzip/tar/zip files

client

copy response body to a file if not zip.tar/gzip type

s

* Moved support protocols to protocols

* fixed variable reference

* support for http protocol

* update prefix to be clearly invalid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants