Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait_job command #1505

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Add wait_job command #1505

merged 1 commit into from
Jun 13, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Jun 13, 2019

Extract wait job logic from create_job command and make it as an individual command.
This command can enable scenario when user has an existing component which submits a CMLE job. They can use the wait_job command to wait until the job finishes.

The command supports:

  • Cancellation when the pipeline is cancelled.
  • Fail if the job is in failed state.
  • Output display metadata including job links and tensor-board link.

Some side changes are also included in the PR:

  • Remove the need of requirements.txt file.
  • Support pass args to pytest via tox.

This change is Reviewable

@gaoning777
Copy link
Contributor

/lgtm

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1d55a27 into kubeflow:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants