Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add op_to_templates_handler to compiler #1458

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Jun 6, 2019

The handler is required by injecting metadata tracking steps for ContainerOps.


This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 6, 2019

/lgtm

  1. Should we have something similar for _group_to_template ?
  2. Do you think we should handle the non-unique template names?

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 6, 2019
@hongye-sun
Copy link
Contributor Author

hongye-sun commented Jun 6, 2019

Should we have something similar for _group_to_template ?

It's not required for now. We can add it as needed in the future.

Do you think we should handle the non-unique template names?

I think so, though it's not important for now. I am going to use the current template name which has already been dedup and append suffix for internal steps. It is unlikely to have dup problem.

@gaoning777
Copy link
Contributor

/lgtm

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b1fa929 into kubeflow:master Jun 7, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants