Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for deserializing a string of a dict for typemeta #1439

Merged
merged 2 commits into from
Jun 6, 2019
Merged

remove support for deserializing a string of a dict for typemeta #1439

merged 2 commits into from
Jun 6, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Jun 4, 2019

resolves #1417

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 5, 2019

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

2 similar comments
@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 5, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 5, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 5, 2019

@rileyjbauer The frontend integration tests seems to be failing a lot here...

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 5, 2019

/test kubeflow-pipeline-e2e-test

4 similar comments
@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 5, 2019

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 6, 2019

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 6, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 6, 2019

/lgtm

@gaoning777 gaoning777 merged commit 9f97a94 into kubeflow:master Jun 6, 2019
@gaoning777 gaoning777 deleted the remove-type-support-for-string-of-a-dict branch June 6, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants