Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Controlling which modules are captured with Lightweight components #1435

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jun 4, 2019

All func_to_* functions now accept the modules_to_capture parameter: List of module names that will be captured (instead of just referencing) during the dependency scan. By default the func.module is captured.


This change is Reviewable

@Ark-kun Ark-kun requested a review from gaoning777 June 4, 2019 02:08
@k8s-ci-robot k8s-ci-robot requested a review from hongye-sun June 4, 2019 02:08
@Ark-kun Ark-kun force-pushed the SDK---Controlling-which-modules-are-captured-with-Lightweight-components branch from bedb157 to 48c2068 Compare June 4, 2019 02:13
All func_to_* functions now accept the modules_to_capture parameter: List of module names that will be captured (instead of just referencing) during the dependency scan. By default the func.__module__ is captured.
@Ark-kun Ark-kun force-pushed the SDK---Controlling-which-modules-are-captured-with-Lightweight-components branch from 62bf987 to f4d83ea Compare June 7, 2019 01:24
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 7, 2019

/cc @gaoning777

@gaoning777
Copy link
Contributor

Thanks for extending the code picking functionality. Synced offline:

  1. add documentations to explicit explain the codes to be pickled.
  2. add tests to validate the code that is not depended upon is not pickled.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 7, 2019

  • add documentations to explicit explain the codes to be pickled.
  • add tests to validate the code that is not depended upon is not pickled.

Both done.

Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 8, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants