Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize ResourceOp samples #1433

Merged
merged 3 commits into from
Aug 1, 2019

Conversation

elikatsis
Copy link
Member

@elikatsis elikatsis commented Jun 4, 2019

Move the samples to different directories for the users to easier navigate to the desired usage demonstration.

Also add READMEs under samples/volumes/ and samples/snapshots/ with some documentation.


This change is Reviewable

@elikatsis
Copy link
Member Author

Hey @gaoning777, any opinion on this PR?

@gaoning777
Copy link
Contributor

Hey, Ilias, thanks for your contribution. I'm trying to collect some teamwide feedback in terms of the samples and sample test plans during the past two days. I will respond soon. Thanks

@elikatsis
Copy link
Member Author

/retest

@elikatsis
Copy link
Member Author

Hi there!

Any update on this?
It could supplement the work I'll be doing regarding the documentation of ResourceOps and the rest of the entities (kubeflow/website#757, kubeflow/website#758).

Thanks!

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 1, 2019

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 1, 2019

/cc @gaoning777

@gaoning777
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8866747 into kubeflow:master Aug 1, 2019
@elikatsis elikatsis deleted the reorganize-resourceop-samples branch March 9, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants