-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tensorboard routing rule #143
Conversation
/assign @yebrahim |
test/presubmit-tests.sh
Outdated
@@ -77,7 +77,7 @@ if [ "$CLUSTER_TYPE" == "create-gke" ]; then | |||
echo "Delete cluster..." | |||
gcloud container clusters delete ${TEST_CLUSTER} --async | |||
} | |||
trap delete_cluster EXIT | |||
# trap delete_cluster EXIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove or add [WIP] to the PR to remember to remove this.
@@ -56,6 +57,46 @@ | |||
}, | |||
}, //serviceUi | |||
|
|||
tensorboardUi: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: rename to tensorboardData? The rest of the UI renders fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan, yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
* add tensorboard routing rule * rename tb routing rule * address comments * remove debugger * fix url prefix
* add tensorboard routing rule * rename tb routing rule * address comments * remove debugger * fix url prefix
* add pipeline e2e test back * delete samples * more changes to pipeline test * add delete run/experiment * update test name * stage * add api * fii * add tensorboard routing rule (#143) * add tensorboard routing rule * rename tb routing rule * address comments * remove debugger * fix url prefix * more fixes * update tests * revert debugging * update * update test * fix * update test * fix * fix pipeline tests * exp * update run * update jobs
* We'd been using projects but not everyone can see projects.
…eflow#143) * Adds a mutating admission controller to inject GPU functionality into deployments * Updates * Added documentation * Pausing to sync github * Added tests for tolerations and nodeselectors * Added tensorflow support for GPUs * Passthrough annotation to configurations * Fix readme * Fixed runtime versions for tensorflow * fixed an annotation type * Added ignored framework files * Removed unnecessary dependency * Fixed a typo in README * Refactored tests * added a space * Made mutate a private method * Cleaned up paths
* PipelineRun with embedded pipelineSpec and taskSpec Closes #143 * Preserve empty string default values * Remove success_condition and failure_condition
fix(backend): upgrading go to fix CVE-2024-45336
This change is