Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Dynamically installing cloudpickle module #1429

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jun 3, 2019

Fixes #1426


This change is Reviewable

@gaoning777
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 3, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 16213ba into kubeflow:master Jun 3, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
…w#1429)

* Renaming puller method to be more descriptive, waiting for events to be drained before starting watcher

* Changing wait logic and adding unit test

* Waiting for Add opstats to equal 1 for all models

* Adding in watchergroups and differentiating startup events vs watcher events

* Fixing test and taking out debug log

* Wrapping waitGroup to avoid lock passed by value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudpickle import error
3 participants