Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API package names and regenerate checked-in proto files. #1404

Merged
merged 3 commits into from
May 30, 2019

Conversation

neuromage
Copy link
Contributor

@neuromage neuromage commented May 30, 2019

Also bump version of GRPC gateway used.


This change is Reviewable

@neuromage
Copy link
Contributor Author

/assign @IronPan

Fixes #1212

@IronPan
Copy link
Member

IronPan commented May 30, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 30, 2019
@IronPan
Copy link
Member

IronPan commented May 30, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 5f1b411 into kubeflow:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants