Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up repo - delete unnecessary top level folders #1323

Merged
merged 1 commit into from
May 14, 2019
Merged

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented May 14, 2019

.vscode/ is checked in by accident.
tools/collector is Spartans specific which is no longer being used.
experimental/ doesn't have any valid experiments. we can recreate when needed.


This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented May 14, 2019

third_party has just 1 file
Backend-related files like go.sum, go.mod, BUILD.bazel, WORKSPACE, Makefile can probably go to /backend
contrib can be moved to /samples and /components
component_sdk can be moved to /components/gcp/
proxy probably should not be top level. (Maybe have /deploy folder and put both /manifests and /proxy there?)

@Ark-kun
Copy link
Contributor

Ark-kun commented May 14, 2019

/lgtm

@IronPan
Copy link
Member Author

IronPan commented May 14, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan IronPan merged commit 0a94fc7 into master May 14, 2019
@IronPan IronPan deleted the cleans branch May 30, 2019 07:16
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants