-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mpi job into arena launcher #1307
Conversation
/assign @Ark-kun |
/lgtm |
@wsxiaozhang: changing LGTM is restricted to assignees, and only kubeflow/pipelines repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@wsxiaozhang: changing LGTM is restricted to assignees, and only kubeflow/pipelines repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can you please remove the Also, can you please use PNG for screenshots in future? It has better quality and smaller size. Other than this |
env=[], data=[], sync_source=None, | ||
metrics=['Train-accuracy:PERCENTAGE'], | ||
arena_image='cheyang/arena_launcher:v0.6', | ||
arena_image='cheyang/arena_launcher:v0.7', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my pet peeve :-) Let`s try and move away from docker repos tied to an individual - doesn't give confidence over the maintainability of the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, do you have any guidance?
First, install the necessary Python Packages | ||
```shell | ||
pip3 install http://kubeflow.oss-cn-beijing.aliyuncs.com/kfp/0.1.16/kfp.tar.gz --upgrade | ||
pip3 install http://kubeflow.oss-cn-beijing.aliyuncs.com/kfp-arena/kfp-arena-0.6.tar.gz --upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason these python packages cannot submitted to universal python package library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I give this link because it's accessible from China. I will try to see how submit to universal python package library, thanks.
/ping @Ark-kun, I've updated according to your comments. Thanks. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun, wsxiaozhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun, wsxiaozhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
arena_launcher.py
into multiple modules to make it easy to iterateThis change is