Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the kubeflow-tf sample README #130

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

sarahmaddox
Copy link
Contributor

@sarahmaddox sarahmaddox commented Nov 7, 2018

Fixed a link. Clarified YAML vs TAR format for workflow specification. Made other textual improvements.


This change is Reviewable

Fixed a link. Clarified YAML vs TAR format for workflow specification. Made other textual improvements.
@qimingj
Copy link
Contributor

qimingj commented Nov 8, 2018

/lgtm

@qimingj
Copy link
Contributor

qimingj commented Nov 8, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 72a910c into master Nov 8, 2018
@IronPan IronPan deleted the sarahmaddox-kubeflowtf-readme branch June 4, 2019 07:31
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Update dev.kubeflow.org

* Update dev.kubeflow.org to use master so that we can see the latest changes.
* In particular we want to see the central UI
* recreate_app.sh shouldn't hardcode the client secret; the secret is
  created from a GCS file by redeploy_app.sh

* Update the README; the command for redeploy_app.sh was incorrect.
* Recreate the default environment because the cluster has changed.

Related to kubeflow#805 Verify Central UI is working.

* Autoformat jsonnet.

* * Modify recreate_app.sh so we automatically check out the files from master
  for the GitHub issue summarization example. Those won't be recreated
  automatically.

* Restore params.

* Autoformat all the files.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines Mar 11, 2024
HumairAK added a commit to HumairAK/data-science-pipelines that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants