Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets the background color for KFP pages #1281

Merged
merged 1 commit into from
May 3, 2019

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented May 3, 2019

This will prevent the pages from appearing gray when viewed within the
iframe of the greater Kubeflow console.


This change is Reviewable

This will prevent the pages from appearing gray when viewed within the
iframe of the greater Kubeflow console.
@IronPan
Copy link
Member

IronPan commented May 3, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rileyjbauer rileyjbauer merged commit 41b8fc2 into kubeflow:master May 3, 2019
hamedhsn pushed a commit to hamedhsn/pipelines that referenced this pull request May 5, 2019
This will prevent the pages from appearing gray when viewed within the
iframe of the greater Kubeflow console.
@rileyjbauer rileyjbauer deleted the color-background branch May 6, 2019 22:11
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Set enable puller flag

* Fix loggers

* Logging load/unload events

* Fix enable model puller flag

* Remove logger

* Remove unused code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants