Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep the api image name consistent between the presubmit test and staging #1279

Merged
merged 1 commit into from
May 4, 2019
Merged

keep the api image name consistent between the presubmit test and staging #1279

merged 1 commit into from
May 4, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented May 3, 2019

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from IronPan and vicaire May 3, 2019 17:06
@gaoning777 gaoning777 removed the request for review from vicaire May 3, 2019 17:07
@IronPan
Copy link
Member

IronPan commented May 4, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d0429b6 into kubeflow:master May 4, 2019
hamedhsn pushed a commit to hamedhsn/pipelines that referenced this pull request May 5, 2019
@gaoning777 gaoning777 deleted the api-image-name-bug branch May 6, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants