-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate UI of toolbars for AllRunsList and ExperimentList #124
Conversation
a6493e1
to
f11c3d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/lgtm |
Closes #52
UPSTREAM: 11469: fix(backend): Synced ScheduledWorkflow CRs on apiserver startup
Fixes: #71
Keeps
Experiments
button/tab on the side-nav highlighted for all non-pipeline pages, includingRecurringRunDetails
andCompare
.Changes the title on the
AllRunsList
page to match that of theExperimentList
page and addsCreate new experiment
button toAllRunsList
Note that we probably should truly merge these pages at some point.
This change is