Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize-wml-pipeline #1227

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Conversation

animeshsingh
Copy link
Contributor

@animeshsingh animeshsingh commented Apr 25, 2019

Base it on components.yaml, and expose the parameters


This change is Reviewable

@Ark-kun Ark-kun self-assigned this Apr 25, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 25, 2019

/lgtm

@animeshsingh
Copy link
Contributor Author

guess this can be merged @Ark-kun @vicaire

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 25, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 25, 2019

guess this can be merged @Ark-kun @vicaire

Sure.
It's just that usually the PR author approves the PR if he's the owner - making the final call.

@vicaire vicaire merged commit f6283d4 into kubeflow:master Apr 25, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* add pointer to OpenShift

* add AIX 360 in main sample directory

* add reference to LIME

* update  containers UID 0 section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants